Performance tests #1301
Merged
Performance tests #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update flow to include support for the migration screen.
We measure app startup time in LoginTests as part of the flow - we may as well avoid spending 60s doing only that measurement in ApplicationTests
This reverts commit 8670710.
Generated by 🚫 Danger Swift against 7fd7816 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1301 +/- ##
===========================================
- Coverage 40.16% 40.06% -0.10%
===========================================
Files 434 435 +1
Lines 27676 27751 +75
Branches 14204 14232 +28
===========================================
+ Hits 11115 11118 +3
- Misses 16264 16335 +71
- Partials 297 298 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pixlwave
reviewed
Jul 10, 2023
Velin92
approved these changes
Jul 11, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seek to split out the performance tests into:
At present I'm comfortable with the timings for launch, login and first sync, but room join seems to have a 20s delay that I'm not expecting.
This is now running fairly stability on the GHA runner so if/when we merge we should let it run for a week or so to gather information on reliability of the tests.
Before merging, I would like to delete the test that just check application launch time - we can pull that metric from the main test. I tried to do so already but there was a complaint about missing files in the build, so this may be something to do with generated project configurations I'm not sure about.